Edit Site: Refactor business logic into store. #22844
Conversation
epiqueras
added
[Type] Code Quality
epiqueras
requested review from
ellatrix,
etoledom,
jorgefilipecosta,
nerrad,
SergioEstevao,
spacedmonkey,
talldan,
TimothyBJacobs and
youknowriad
as code owners
|
Size Change: +1.09 kB (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
This is looking great and cleans things up quite a bit. Thank you!
Reading through the code changes things look good.
From what I can tell mostly everything in the site editor works as expected in testing. However, I notice that when I test the template switcher's "Overwrite Template" / "Revert to Parent" functionality for a page, the revert doesn't go through as on Master. Eventually get a 410 console error with Uncaught (in promise) {code: "rest_already_trashed", message: "The post has already been deleted.", data: {…}}
|
Oops, I missed that part while refactoring. All done now 😄 |
| /** | ||
| * Returns the current template IDs. | ||
| * | ||
| * @param {Object} state Global application state. | ||
| * | ||
| * @return {number[]} Template IDs. | ||
| */ | ||
| export function getTemplateIds( state ) { | ||
| return state.templateIds; | ||
| } |
There was a problem hiding this comment.
AFAICS, the getTemplateIds selector isn't used anywhere. We could consider dropping it (and the corresponding templateIds reducer, plus potentially some related actions, resolvers, and editorInitialState).
There was a problem hiding this comment.
I think they might come in handy down the road though? If I'm understanding it right their values are being initialized from the edit-site-page.php, so now getting them will be easily accessible in future development. I'm assuming there are plans to use this (I'm kind of surprised its not already)?
There was a problem hiding this comment.
|
Nice to see this PR. Thanks @epiqueras |
Description
This PR refactors all of the
edit-sitebusiness logic and editor state into the store.It also moves a local utility,
getPathAndQueryString, into the@wordpress/urlpackage.How has this been tested?
Tests were written for all the new functions, and it was verified that nothing changed in the site editor.
Types of Changes
New Feature:
@wordpress/urlnow has agetPathAndQueryStringutility.Checklist: