-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts: Remove temporary workaround in ESLint config #22915
Conversation
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
@gziolo I'm not sure how to test this. At least The testing steps from #17744 don't work because the line to remove doesn't exist anymore. I also think that |
Indeed it might be difficult to test. How about we wait until ESLint 7 changes are published to npm (next week) and then testing will be as easy as apply the same change in node_modules folder? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the latest changes published to npm, it works great 👍
Description
This reverts #17744 now the scripts have been updated to ESLint 7.x, see #22771 and the comment from @gziolo in #22385.
How has this been tested?
Not yet
Types of changes
Revert
Checklist: