Update Post Author block - Support changing bio/byline sizes. #23012
Conversation
|
Size Change: +105 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
@epiqueras - you also mentioned we should refactor to use __experimentalUseColors (#22877 (comment))
Is that different than what we are currently using here?
gutenberg/packages/block-library/src/post-author/edit.js
Lines 71 to 76 in 8ac2826
I was assuming there was another implementation being referred to that we would add to the "supports" field in the block.json similar to __experimentalFontSize, but haven't found anything similar being used elsewhere for colors.
|
Yes, it's I'm not sure a UI for adjusting the relative font sizes makes sense here. This feels like something that should be handled by the theme. If we really do need the customization, perhaps the different pieces should be their own child blocks. What do you think @mtias @youknowriad ? |
Agreed. We have also been staying away from using sliders for font sizes. If we want granular control over the display (color, text, etc) we should be basing it on child blocks. I think it's fine to wait a bit for that and see what themes expect to do. |
That sounds fair enough. We can drop the relative sliders then, and I'l just focus on implementing the |
Addison-Stavlo
added
[Status] In Progress
|
closing this. |
Description
As a follow-up to #22877 - this now allows the user to select and save the relative sizes for their byline and bio text. Previously, these sizes were set to a fixed ratio of the standard set font size.
How has this been tested?
Tested between post editor, site editor, and front-end on local docker environment.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: