Popover: Ensure popovers consider border width's in their positioning. #23035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r accounts for the boderwidth.
shaunandrews
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
|
Size Change: +1 B Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
Works like a charm on both 1x and retina using 🔥 🦊 latest. Tried at various viewport widths. I did also look at the more menu on the block toolbar. It looks like maybe a similar issue. On master: On this branch (slightly better): |
jasmussen
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Beautiful. Thanks for this.
To me it seems to work as intended, and it's a vast improvement over what's shipping.
2x:
1x:
As far as I can tell, there isn't any subpixel positioning going on, only abs positioning:
This might still align to the wrong pixel in cases of course, but it should align to the wrong whole pixel at least.
Furthermore, I believe that might be improved by #22640
Agreed. I think this is good to go as is. |
ZebulanStanphill
added
[Type] Bug
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, popovers are displayed 1px off the grid. This causes them to not line up with things like the block toolbar. Here's how it looks in
mastercurrently:If you look closely, you'll notice that the left side of the popover is 1px off to the right from the left side of the toolbar.
This PR adjusts the margins of the popover component to use the grid SCSS variable and adds in the
$border-widthvariable to account for the width of the borders. It ends up looking like this: