Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Edit: REST API Code Cleanup #23037

Merged
merged 7 commits into from
Jun 11, 2020
Merged

Image Edit: REST API Code Cleanup #23037

merged 7 commits into from
Jun 11, 2020

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Jun 9, 2020 •
edited
Loading

Description

This is the code cleanup for the REST API that didn't make it into #21024.

How has this been tested?

Apply edits to images

Screenshots

Types of changes

Code Quality

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ajlende ajlende added REST API Interaction Related to REST API [Type] Code Quality Issues or PRs that relate to code quality [Block] Image Affects the Image Block labels Jun 9, 2020
@ajlende ajlende self-assigned this Jun 9, 2020
@ajlende ajlende mentioned this pull request Jun 9, 2020
Merged
6 tasks
@ajlende ajlende marked this pull request as ready for review June 9, 2020 19:33
@TimothyBJacobs
Copy link
Member

This looks great to me, thanks for making these changes @ajlende! Looks like there is a minor PHPCS failure.

TimothyBJacobs
TimothyBJacobs approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@TimothyBJacobs TimothyBJacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks for making these changes!

@ajlende ajlende merged commit 1fd4ed3 into WordPress:master Jun 11, 2020
@ajlende ajlende deleted the fix/image-edit-rest-api branch June 11, 2020 19:10
@github-actions github-actions bot added this to the Gutenberg 8.4 milestone Jun 11, 2020
@ellatrix ellatrix mentioned this pull request Jun 16, 2020
Closed
12 tasks
This was referenced Jun 24, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyBJacobs TimothyBJacobs TimothyBJacobs approved these changes

@Soean Soean Soean approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@talldan talldan Awaiting requested review from talldan

Assignees

@ajlende ajlende

Labels
[Block] Image Affects the Image Block REST API Interaction Related to REST API [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 8.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ajlende @TimothyBJacobs @Soean