Make link color control opt-in #23049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
ellatrix,
spacedmonkey,
TimothyBJacobs and
youknowriad
as code owners
7 tasks
youknowriad
reviewed
Jun 10, 2020
| const { colors, gradients } = useSelect( ( select ) => { | ||
| return select( 'core/block-editor' ).getSettings(); | ||
| }, [] ); | ||
| const { colors, gradients, __experimentalEnableLinkColor } = useSelect( |
There was a problem hiding this comment.
do you think it's possible to use the useFeature hook introduced by @gziolo or is it only for theme.json for now?
There was a problem hiding this comment.
yeah, it only reads from theme.json at the moment and not yet from add_theme_support
|
Size Change: +23 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Jun 10, 2020
|
I'll land when the CI error is fixed. Probably #23052 will do. |
oandregal
pushed a commit
that referenced
this pull request
Jun 10, 2020
oandregal
pushed a commit
that referenced
this pull request
Jun 10, 2020
- Edit Site: fix template lookup. #22954 - Fix for FSE template parts: #23050 - Fix link color style rule. #23025 - Fix for link color: it needs to be opt-in. #23049 - Revert "Image Block: add caption field to placeholder" #23027 - Cover padding: reset button + hook namespace + improve visualizer #23041 - Fix failing 'Build artifacts' CI job (by updating `package-lock.json`): #23052
12 tasks
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In landing #22722 we missed that this control should be opt-in at the moment.