Build: Replace "release" with "build" in script for building a package #23063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
gziolo
reviewed
Jun 12, 2020
|
Ideally, it would just do the release :) what's preventing us from doing everything in the command like the plugin release? |
That should probably be a separate script/command which leverages build-plugin-zip.sh for building the ZIP. |
ocean90
force-pushed
the
fix/rename-package-build-script-intro
branch
from
e570235
to
1a71c53
Compare
gziolo
approved these changes
Jun 12, 2020
|
@youknowriad, I think that sometimes you might still want to test the zip file locally. |
The release command could stop and ask for confirmation like we do for plugins. |
Makes it easier to replace the underlying script without updating the docs
|
ooohh, I just read this properly, don't mind my comments. I was thinking about the "npm release command" while this is clearly about the plugin zip script. I'm not awake properly this morning :P |
mcsf
approved these changes
Jun 12, 2020
This was referenced Jun 24, 2020
Closed
aduth
added a commit
to WordPress/gutenberg.run
that referenced
this pull request
Jun 28, 2020
See: WordPress/gutenberg#23063 Changed from `package-plugin` to `build:plugin-zip`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was quite confusing to read "Time to release Gutenberg" after running the
npm run package-plugincommand. I immediately cancelled the task and had to check the source first if it's really doing a release. Well, it doesn't… 😓