Refactor ToggleControl to use functional component #23116
Conversation
sc81
requested review from
ajitbohra,
chrisvanpatten,
Soean,
talldan and
youknowriad
as code owners
ZebulanStanphill
added
[Feature] UI Components
| onChange, | ||
| } ) { | ||
| function onChangeToggle( event ) { | ||
| onChange( event.target.checked ); |
There was a problem hiding this comment.
The previous onChange handler was checking whether the onChange prop was set or not. Should we do the same?
There was a problem hiding this comment.
The onChange prop is required, without this prop the component will not be usable. When prop is undefined the JS engine will report an error, so the programmer will know what he did wrong.
There was a problem hiding this comment.
Makes sense and it's also documented as such in the README.
|
Congratulations on your first merged pull request, @sc81! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
github-actions
bot
added
the
First-time Contributor
No description provided.