Buttons block: remove margin from last button #23319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
[Block] Buttons
|
Size Change: +295 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jun 19, 2020
|
|
||
| .wp-block-button:last-child { | ||
| margin-right: 0; | ||
| } |
There was a problem hiding this comment.
good catch. Do you think we should remove this margin in all cases, not just the aligned centered buttons? (And the left margin in case of the aligned right ones?
There was a problem hiding this comment.
Makes sense. Done in the last commit: aed2ea7.
| Before | After |
|---|---|
 |
 |
ZebulanStanphill
approved these changes
Jun 20, 2020
Aljullu
changed the title
This was referenced Jun 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23318.
Description
The Buttons block adds right margin to each block so they are spaced. However, when buttons are centered, last button's margin pushes all buttons to the left. This PR removes the right margin of the last button in the Buttons block when they are centered.
How has this been tested?
It's a pretty small change, the easiest way to test is creating a buttons block, center the buttons and verify the last one doesn't have right margin that pushes everything to the left.
Screenshots
Before:
After:
