Classic block: save content bug fix #23408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Bug
|
Size Change: +67 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
Looks good to me |
glendaviesnz
changed the title
glendaviesnz
removed
the
[Status] In Progress
6 tasks
ntsekouras
reviewed
Jun 25, 2020
| @@ -112,6 +121,20 @@ export default class ClassicEdit extends Component { | |||
| bookmark = null; | |||
| } ); | |||
|
|
|||
| editor.on( | |||
| 'Paste Change input Undo Redo', | |||
| debounce( () => { | |||
There was a problem hiding this comment.
Why are you using debounce here? Just not to fire more times when these events are triggered?
There was a problem hiding this comment.
We figured that this could be a very noisy call as someone is typing, making lots of changes, etc., and we don't need every tiny change detected to go through this cycle.
We didn't actually start to see any visible performance degradation until you got upwards of 50,000 words in a post, and adding a debounce made it performant again even with a massive post.
Although people are never likely to have huge posts like that we didn't think it would hurt to add this in anyway, and the debounce time could probably even be raised. Open to feedback on whether we keep this, increase time, etc.
There was a problem hiding this comment.
we didn't think it would hurt to add this in anyway
I believe that too and I also think that 250 is a fair debounce time.
It's great that you have made some tests checking performance! 👍
ntsekouras
approved these changes
Jun 26, 2020
added 6 commits
June 29, 2020 09:00
…eloading editor content
glendaviesnz
force-pushed
the
fix/classic-block-content-save-bug
branch
from
f5d45f5
to
edb8ec1
Compare
|
Thanks @ntsekouras, did you have any thoughts on this one #23376? |
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #22935
Fixes: #15577
Uses the TinyMCE change events to push changed content back out to gutenberg instead of just relying on the onblur event
How has this been tested?
Manually
Screenshots
Before:
After:
Types of changes
Checklist: