Stabilize __experimentalMoverDirection InnerBlocks prop and rename to orientation #23416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
requested review from
ajitbohra,
ellatrix,
mkaz,
Soean and
youknowriad
as code owners
talldan
changed the title
__experimentalMoverDirection to __experimentalBlockListOrientation
talldan
commented
Jun 24, 2020
packages/block-editor/src/components/block-list/block-popover.js
Outdated
Show resolved
Hide resolved
|
Size Change: -266 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jun 24, 2020
| @@ -45,7 +45,7 @@ function UncontrolledInnerBlocks( props ) { | |||
| forwardedRef, | |||
| templateInsertUpdatesSelection, | |||
| __experimentalCaptureToolbars: captureToolbars, | |||
| __experimentalMoverDirection, | |||
| __experimentalBlockListOrientation, | |||
There was a problem hiding this comment.
maybe it could be just "orientation" and make it stable? do we expect any other changes to this API?
There was a problem hiding this comment.
I don't think so, sounds good to me to stabilize it.
talldan
force-pushed
the
rename/experimental-mover-direction-to-block-list-orientation
branch
from
ed7a33d
to
288e652
Compare
talldan
force-pushed
the
rename/experimental-mover-direction-to-block-list-orientation
branch
from
af82e63
to
1c73a82
Compare
talldan
commented
Jul 1, 2020
| clientIds={ blockClientIds } | ||
| __experimentalOrientation={ moverDirection } | ||
| /> | ||
| <BlockMover clientIds={ blockClientIds } /> |
There was a problem hiding this comment.
Removed the not needed prop here.
talldan
commented
Jul 1, 2020
| @@ -195,7 +194,6 @@ function BlockPopover( { | |||
| <BlockSelectionButton | |||
| clientId={ clientId } | |||
| rootClientId={ rootClientId } | |||
| moverDirection={ moverDirection } | |||
There was a problem hiding this comment.
Made BlockSelectionButton use its own selector instead of requiring a prop.
|
This should be ready for a re-review. It's largely just a re-name apart from the two comments I've mentioned above. The property is now called Is there a good label for this change? I'm not sure if |
talldan
changed the title
youknowriad
added
[Type] New API
youknowriad
approved these changes
Jul 1, 2020
|
yes, New API sounds good. thanks @talldan |
youknowriad
reviewed
Jul 1, 2020
Co-authored-by: Riad Benguella <benguella@gmail.com>
talldan
changed the title
talldan
deleted the
rename/experimental-mover-direction-to-block-list-orientation
branch
|
Are we expecting more than two orientations? If it's a binary thing, a boolean prop could avoid a string, which I think is a bit cleaner. |
|
I think a binary doesn't convey the right message. You can say Whether we'll have other values, I'm not sure but potentially something like "grid" could be supported or "both". |
This was referenced Jul 2, 2020
|
@youknowriad Makes sense :) |
|
I’d loooove grid someday! Thanks for stabilising this API yall! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #23020 (comment), the
__experimentalMoverDirectionblock list setting is now being use for a lot more than establishing the mover direction. While it's experimental and not stable, it'd be a good opportunity to rename it.This PR changes it to
__experimentalBlockListOrientation. Other suggestions welcome.Should we also consider stabilizing/documenting this API?
How has this been tested?
Manual testing
Types of changes
Non-breaking code quality
Checklist: