Polish sidebar controls #23578
Polish sidebar controls #23578
Conversation
|
Size Change: -135 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
Amazing attention to detail! Tested it and it all worked as expected 👍 |
There was a problem hiding this comment.
Great improvements! A couple of small things I noticed testing in Windows in high contrast mode:
- The "move to trash" button now doesn't look like a button or link at all:
I guess this is a problem for all tertiary buttons. Could we give them an outline of some kind that would be distinguishable from the focus outline? Or perhaps a transparent bottom border or something?
- There's no way of telling which radio button is selected when they are not focused:
(this was an existing issue, not sure what the best solution might be)
|
Thank you Isabel, those are wonderful observations. I'll get right on those and we'll ship this after. |
|
I added a dotted transparent outline around tertiary buttons, which shows up in high contrast mode:
Note that the above screenshot is scaled down so it gets fuzzy, but the outline is plenty visible. I can't reproduce the radio button issue, to me they look correct regardless of focus:
Where did you see this issue? Thanks again. |
|
I'm going to merge this one with the reviews, and I will be happy to address any followups. |
On both Firefox and IE11, Windows 10, in high contrast mode. The only browser that seems to be showing them correctly is Edge (both the legacy and the new Chromium-based version) |
Ah, yes, both Firefox and Chrome have historically not leveraged the high contrast mode very well. I believe Chrome didn't support it for the longest time virtually at all, though perhaps with chromium based edge that might have changed recently. I'm going to take a look at a followup next week. Thanks for the clarification! |
|
#23706 fixes the checkbox control issue. If you know of any existing tickets that closes, would appreciate if you add it as a "fixes" comment. |
This PR polishes controls in the sidebar.
It styles the checkbox control to better match the styles outlined in #18667:
It styles the toggle control the same way:
... And the radio control:
It fixes a bug where the post-publish sidebar was 1px off. Before:
After: