Scripts: Exclude node_modules from source map processing in start script #23711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Bug
gziolo
force-pushed
the
fix/exclude-node-modules-source-map
branch
from
1a646e2
to
b93c82b
Compare
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
|
Yep, this is the requested change :) |
youknowriad
reviewed
Jul 7, 2020
| @@ -177,6 +177,7 @@ if ( ! isProduction ) { | |||
| config.devtool = process.env.WP_DEVTOOL || 'source-map'; | |||
| config.module.rules.unshift( { | |||
| test: /\.js$/, | |||
| exclude: [ /node_modules/ ], | |||
There was a problem hiding this comment.
Is this intended? Just want to make sure we have a way to debug wordpress packages on Core. (not sure this has an impact though, Core might not use wordpress/scripts yet)
There was a problem hiding this comment.
There is completely separate process in WP Core, even when we use @wordpress/scripts we will use a custom webpack config. It shouldn’t have an impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #23513.
From @leoloso:
How has this been tested?
npm startin the test plugin.