Fix drag and drop to empty block lists #23923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Feature] Drag and Drop
talldan
added
the
[Type] Regression
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
adamziel
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
Works as described, thank you!
In Media & Text, the empty block list is only 8px high, and the user has to drag over this tiny element before being able to drop.
In Group, the Button Appender doesn't highlight very clearly as a drop target—it shows a border above it like other drop targets. I feel like this might have regressed separately at some point.
I think the drop area in Media & Text block should be the entire space to the right of the media, not just the actual space occupied by the empty block list. What do you think?
ellatrix
pushed a commit
that referenced
this pull request
Jul 20, 2020
6 tasks
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since #23020, dragging to an empty block lists hasn't worked.
This PR fixes the issue, though I think there are two separate issues that could improve the situation further:
I'll also start writing some E2E tests so that there's coverage for some of these complex behaviors.
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: