Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post Tags: Feature Parity for Customization #24069

Merged
merged 9 commits into from
Aug 3, 2020
Merged

Post Tags: Feature Parity for Customization #24069

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c9aaaa1
Add comment to check post_tag taxonomy
jeyip Jul 23, 2020
4578334
Update comment phrasing to account for custom post types
jeyip Jul 23, 2020
f04224a
Undo changes to server side rendered post tags blocks
jeyip Jul 23, 2020
31d362b
Add light block wrapper to post tags
jeyip Jul 28, 2020
df1191b
Reintroduce wrapping div to server side rendered block
jeyip Jul 28, 2020
50dcf2e
Add color support to post tag block
jeyip Jul 20, 2020
3af770a
Add font size and line height controls
jeyip Jul 29, 2020
136f87f
Add editor post tags text alignment
jeyip Jul 29, 2020
c4a94df
Add post tags text alignment to frontend
jeyip Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/block-library/src/post-tags/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,20 @@
{
"name": "core/post-tags",
"category": "design",
"attributes": {
"textAlign": {
"type": "string"
}
},
"usesContext": [ "postId", "postType" ],
"supports": {
"html": false,
"lightBlockWrapper": true
"lightBlockWrapper": true,
"__experimentalFontSize": true,
"__experimentalColor": {
"gradients": true,
"linkColor": true
},
"__experimentalLineHeight": true
}
}
36 changes: 33 additions & 3 deletions packages/block-library/src/post-tags/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,24 @@
/**
* External dependencies
*/
import classnames from 'classnames';

/**
* WordPress dependencies
*/
import { useEntityProp } from '@wordpress/core-data';
import { Warning, __experimentalBlock as Block } from '@wordpress/block-editor';
import {
BlockControls,
Warning,
__experimentalBlock as Block,
AlignmentToolbar,
} from '@wordpress/block-editor';
import { useSelect } from '@wordpress/data';
import { __ } from '@wordpress/i18n';

export default function PostTagsEdit( { context } ) {
export default function PostTagsEdit( { context, attributes, setAttributes } ) {
const { textAlign } = attributes;

const [ tags ] = useEntityProp(
'postType',
context.postType,
Expand Down Expand Up @@ -65,5 +77,23 @@ export default function PostTagsEdit( { context } ) {
);
}

return <Block.div>{ display }</Block.div>;
return (
<>
<BlockControls>
<AlignmentToolbar
value={ textAlign }
onChange={ ( nextAlign ) => {
setAttributes( { textAlign: nextAlign } );
} }
/>
</BlockControls>
<Block.div
className={ classnames( {
[ `has-text-align-${ textAlign }` ]: textAlign,
} ) }
>
{ display }
</Block.div>
</>
);
}