-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block alignment - remove unnecessary class application for dynamic blocks. #24223
Merged
Addison-Stavlo
merged 10 commits into
master
from
update/block-alignment-application-for-dynamic-blocks
Aug 3, 2020
Merged
Block alignment - remove unnecessary class application for dynamic blocks. #24223
Addison-Stavlo
merged 10 commits into
master
from
update/block-alignment-application-for-dynamic-blocks
Aug 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -1.03 MB (89%) 🏆 Total Size: 1.16 MB
ℹ️ View Unchanged
|
Addison-Stavlo
commented
Jul 27, 2020
Addison-Stavlo
requested review from
noahtallen,
vindl,
ockham,
youknowriad and
Copons
July 27, 2020 18:09
Addison-Stavlo
requested review from
ajitbohra,
Soean and
talldan
as code owners
July 27, 2020 18:09
6 tasks
youknowriad
reviewed
Jul 28, 2020
youknowriad
reviewed
Jul 28, 2020
Addison-Stavlo
added
the
[Status] In Progress
Tracking issues with work in progress
label
Jul 28, 2020
Addison-Stavlo
removed
the
[Status] In Progress
Tracking issues with work in progress
label
Jul 28, 2020
Copons
approved these changes
Jul 29, 2020
Addison-Stavlo
commented
Jul 29, 2020
Addison-Stavlo
commented
Jul 29, 2020
Addison-Stavlo
deleted the
update/block-alignment-application-for-dynamic-blocks
branch
August 3, 2020 20:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a follow up to #24122 - some existing dynamic blocks using the
align
hook now have unnecessary code to apply class names for block alignment. This PR removes these now obsolete bits for the following blocks:How has this been tested?
Tested on local docker environment.
Verify the listed blocks properly have their block align classnames added to the front-end when applicable.
Screenshots
Types of changes
Checklist: