-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Site: Add browse mode. #24252
Closed
Closed
Edit Site: Add browse mode. #24252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epiqueras
added
[Feature] Full Site Editing
[Type] Feature
New feature to highlight in changelogs.
labels
Jul 28, 2020
epiqueras
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
mkaz and
youknowriad
as code owners
July 28, 2020 20:32
Size Change: +529 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
ZebulanStanphill
added
the
Needs Accessibility Feedback
Need input from accessibility
label
Aug 28, 2020
@mtias, @mapk or @MichaelArestad, did you have a chance to test this PR to validate how it fits with what was proposed in #23328? |
Yes, I like this direction but is not immediately a priority. |
I am not sure we should move forward with this yet. @mapk and @dubielzyk followed up with iterations that show promise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Accessibility Feedback
Need input from accessibility
[Status] In Progress
Tracking issues with work in progress
[Type] Feature
New feature to highlight in changelogs.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #23328.
This PR implements browse mode navigation from #23328.
Screenshots
Checklist: