Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix a typo, use plural 1st person, and reword a paragraph. #24340

Merged
merged 3 commits into from
Aug 3, 2020
Merged

Docs: Fix a typo, use plural 1st person, and reword a paragraph. #24340

merged 3 commits into from
Aug 3, 2020

Conversation

vcanales
Copy link
Member

@vcanales vcanales commented Aug 3, 2020

Description

I reworded the WYSIWYG explanation because I found it easier to parse in the new way. I've also added a missing "as possible" to it.

I also found a typo, and changed the usage of "I" for "we", to keep consistency with the rest of the tutorial.

How has this been tested?

Spell-checked, and other than that, looking for a review on the style of the longer paragraph.

Type of changes

Documentation

I found it a bit easier to parse this way. Kind of a stylistic choice,
except for the addition of "as possible" to the phrase.
@vcanales
Copy link
Member Author

vcanales commented Aug 3, 2020

@mkaz, I would appreciate a review here :)

@Soean Soean added the [Type] Developer Documentation Documentation for developers label Aug 3, 2020
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing! 👍

@mkaz mkaz merged commit 2043458 into WordPress:master Aug 3, 2020
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Aug 3, 2020
@github-actions
Copy link

github-actions bot commented Aug 3, 2020

Congratulations on your first merged pull request, @vcanales! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 8.8 milestone Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants