Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use hardcoded values for separator styles #24366

Merged
merged 4 commits into from
Aug 5, 2020
Merged

don't use hardcoded values for separator styles #24366

merged 4 commits into from
Aug 5, 2020

Conversation

aristath
Copy link
Member

@aristath aristath commented Aug 5, 2020

This is a clone of #17076

The fork I had last year for Gutenberg no longer exists so I could no longer push updates to the PR to an Unknown repository. A new PR from a new fork was necessary in order to push the requested updates.

For a full discussion please see the original discussion on #17076

@aristath aristath mentioned this pull request Aug 5, 2020
Closed
5 tasks
@ZebulanStanphill ZebulanStanphill added [Block] Separator Affects the Separator Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Enhancement A suggestion for improvement. CSS Styling Related to editor and front end styles, CSS-specific issues. labels Aug 5, 2020
ZebulanStanphill
ZebulanStanphill approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@ZebulanStanphill ZebulanStanphill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement over master.

A future PR can remove the opacity style from the theme.scss file if desired.

@ZebulanStanphill ZebulanStanphill merged commit 0bfb46f into WordPress:master Aug 5, 2020
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Aug 5, 2020
@github-actions github-actions bot added this to the Gutenberg 8.8 milestone Aug 5, 2020
@aristath aristath deleted the try/16782-separator branch August 5, 2020 19:55
@aristath aristath mentioned this pull request Aug 10, 2020
Closed
@ItsJonQ ItsJonQ mentioned this pull request Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZebulanStanphill ZebulanStanphill ZebulanStanphill approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
[Block] Separator Affects the Separator Block CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 8.8
Development

Successfully merging this pull request may close these issues.
2 participants
@aristath @ZebulanStanphill