Revert "[RNMobile] Fix jumping toolbar" #24388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d86cd5f.
chipsnyder
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
|
Sorry, about that :(. Let's revert it for now, to not block the release and I will investigate it tomorrow ✌️ |
|
Thanks @lukewalczak! I was just getting ready to ping you on this as well on some convo from a side discussion but we were thinking along those same lines that you suggested. Just tested this on my devices and it's working fine with the revert and is ready for review. cc @geriux Also, cc @ceyhun when this merges can we pull it into wordpress-mobile/gutenberg-mobile#2529? |
This was referenced Aug 5, 2020
lukewalczak
approved these changes
Aug 5, 2020
|
Thank you all @chipsnyder @lukewalczak @geriux ! |
ceyhun
pushed a commit
that referenced
this pull request
Aug 6, 2020
ceyhun
added a commit
to wordpress-mobile/gutenberg-mobile
that referenced
this pull request
Aug 6, 2020
Cherry-picked WordPress/gutenberg#24388
5 tasks
cameronvoell
added a commit
that referenced
this pull request
Aug 11, 2020
* Release script: Update react-native-editor version to 1.34.0 * [RNMobile] E2E Android - Use swipe gesture to scroll inserter menu (#24338) * Set autosaveInterval to 1 on mobile (#24353) * Revert "[RNMobile] Fix jumping toolbar (#23684)" (#24388) This reverts commit d86cd5f. * Turn off autosave interval for mobile (#24415) * [RNMobile] Merge release 1.33.1 to master (#24448) * Release script: Update react-native-editor version to 1.33.0 * Update release notes. * Update version numbers for packages. * Revert "Reduce spacing between label and slider control (#23580)" (#24109) This reverts commit 2a67de0. * Release script: Update react-native-* versions to 1.33.1 * Release script: Update with changes from 'npm run core preios' * Allow @ char in posts in mobile editor (#24428) This fixes a bug with the @-mention feature on mobile that made entering the standalone @ character difficult because of the @-mention UI getting in the way. The fix here is to allow the @ character to be intercepted without being consumed by the @ key event logic. * Remove duplicate entry from changelog Co-authored-by: Sergio Estevao <sergioestevao@gmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com> Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com> * Update version numbers * Ran pod install to update podfile.lock Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com> Co-authored-by: Adam Zielinski <adam@adamziel.com> Co-authored-by: Chip <chip.snyder3@gmail.com> Co-authored-by: Cameron Voell <cameronvoell@gmail.com> Co-authored-by: Sergio Estevao <sergioestevao@gmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #23684
This PR reverts the changes in #23684 due to an error that was being generated while trying to layout the Starter Page Template buttons and the bottom bar.
After Revert: