-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSE: Move settings registration to init, remove API name param #24390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- init so that the setting is always registered - the name is redundant in this scenario
noahtallen
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Feature] Full Site Editing
labels
Aug 5, 2020
6 tasks
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
noahtallen
requested review from
vindl,
ockham,
jeyip,
Addison-Stavlo and
Copons
August 5, 2020 22:52
TimothyBJacobs
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up from #23775 (comment).
How has this been tested?
Locally in edit site, e2e's should pass. (if these changes don't work the site editor will not load any page at start)
Screenshots
n/a
Types of changes
Code quality improvements
Checklist: