Prevent <a> tag from being focusable (via tabbing) when inside <Disabled> component. #24397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Disabled>` component.
yansern
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
youknowriad
approved these changes
Aug 6, 2020
youknowriad
reviewed
Aug 6, 2020
| @@ -47,6 +47,10 @@ function Disabled( { className, children, ...props } ) { | |||
| focusable.setAttribute( 'disabled', '' ); | |||
| } | |||
|
|
|||
| if ( focusable.nodeName=='A' ) { | |||
There was a problem hiding this comment.
I think there are some linting issues here
youknowriad
added
the
[Type] Bug
This was referenced Aug 31, 2020
priethor
added
the
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
<a>tag is inside the<Disabled>, it is focusable via tabbing, therefore causing unintended consequences.One such example is when the
<a>tag presents itself inside block previews on block pattern list on the block inserter menu, it causes the<a>to receive focus, and activates the block toolbar unintentionally.See more detail of this issue at: Automattic/wp-calypso#44042
Description
Set
tabindex=-1specifically on<a>nodes when inside<Disabled>component.How has this been tested?
Screenshots
See Automattic/wp-calypso#44042
Types of changes
Bug fix
Checklist: