Update lodash #24401
Merged
Update lodash #24401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
adamsilverstein,
ajitbohra,
atimmer,
cameronvoell,
chrisvanpatten,
ellatrix,
etoledom,
guarani,
gziolo,
mkaz,
nerrad,
oandregal,
ntwb,
Soean,
swissspidy and
talldan
as code owners
|
Size Change: +1.28 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
the e2e test failure here is consistent but I'm not able to find why it's failing. |
|
I'm poking at the E2E test now. So far, no luck! Other folks are more than welcome to give it a shot! 🙏 |
|
@youknowriad Not sure if this is helpful! If I remove the following PHP code from gutenberg_register_vendor_script(
$scripts,
'lodash',
'https://unpkg.com/lodash@4.17.19/lodash.js',
array(),
'4.17.19'
);I'm unsure how the vendor_script code helps in regards to (I'm not saying we remove. It looks like it's important in regards to the lodash versioning. Maybe? 😛 ) Update: Switching the version to gutenberg_register_vendor_script(
$scripts,
'lodash',
'https://unpkg.com/lodash@4.17.15/lodash.js',
array(),
'4.17.15'
);Update 2: As a sanity check, I tried loading a different library ( |
|
Looks like loading on the footer did the trick. Awesome @ntsekouras thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing fancy here, just want to silence some audit messages.