Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename block patterns in translations strings #24457

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Rename block patterns in translations strings #24457

merged 2 commits into from
Aug 10, 2020

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Aug 10, 2020

Description

We have Block Patterns, Block Patterns Category and other Patterns like in Rest API. Users and translators should know what kind of patterns are we talking about.

Screenshots

Different kind of "patterns":
77777-patterns

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ramiy
Rename block patterns in translations strings
cb80e90 
We have `Block Patterns` and other `Patterns` like in Rest API. Users and translators should know what kind of patterns are we talking about.
youknowriad
youknowriad approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks

@youknowriad youknowriad merged commit 1552291 into WordPress:master Aug 10, 2020
@youknowriad youknowriad added [Type] Enhancement A suggestion for improvement. Internationalization (i18n) Issues or PRs related to internationalization efforts labels Aug 10, 2020
@github-actions github-actions bot added this to the Gutenberg 8.8 milestone Aug 10, 2020
@ramiy ramiy deleted the patch-2 branch August 10, 2020 12:38
@ItsJonQ ItsJonQ mentioned this pull request Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@ellatrix ellatrix Awaiting requested review from ellatrix

Assignees
No one assigned
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 8.8
Development

Successfully merging this pull request may close these issues.
2 participants
@ramiy @youknowriad