Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Template Part renaming error. #24500

Merged
merged 3 commits into from
Aug 12, 2020
Merged

Fix Template Part renaming error. #24500

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9412f0e
use initialSlug/theme in useTemplatePartPost call
Addison-Stavlo Aug 11, 2020
27b5d91
useEffect to set postId on block attribute
Addison-Stavlo Aug 11, 2020
61fa1bf
set postId when slug is changed
Addison-Stavlo Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/block-library/src/template-part/edit/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ export default function TemplatePartEdit( {
const initialTheme = useRef( theme );

// Resolve the post ID if not set, and load its post.
const postId = useTemplatePartPost( _postId, slug, theme );
const postId = useTemplatePartPost(
_postId,
initialSlug.current,
initialTheme.current
);
Addison-Stavlo marked this conversation as resolved.
Show resolved Hide resolved

// Set the post ID, once found, so that edits persist,
// but wait until the third inner blocks change,
Expand Down