-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile - iOS] Fix empty rich-text with no height on RTL layout #24510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etoledom
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Aug 12, 2020
Merged
2 tasks
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
3 tasks
guarani
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via wordpress-mobile/WordPress-iOS#14630 (review)
etoledom
force-pushed
the
rnmobile/fix-RTL-lang-empty-rich-text
branch
from
August 14, 2020 08:59
3efa19d
to
022e0f4
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes wordpress-mobile/WordPress-iOS#14477
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2544
WPiOS PR: wordpress-mobile/WordPress-iOS#14630
By testing I noticed that
let newSize = sizeThatFits(frame.size)
was returning 0 height on RTL while it was returning a proper value (around 20 ~ 30) for LTR layout.This is the value used by gutenberg to size the Aztec parent View and give RNAztec its height.
I'm not sure of why or how this stopped working. I tested an older iOS version and has the same problem (12.4).
To test:
Checklist: