Safari Bugfix: Caption jumps when hovering resize handles #24540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
jasmussen
requested review from
ajitbohra,
chrisvanpatten and
youknowriad
as code owners
|
Size Change: +111 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Aug 14, 2020
|
@jasmussen you are my hero. 🙌 Thanks for sorting this out this longstanding bug! |
|
My pleasure Kjell! I only wish there was a nicer workaround. I will keep Safari and the Image block in mind. The current configuration only just strikes the balance between making the caption behave predictably while keeping the markup pure, but it'd be nice if there was a better way overall. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15924.
There's a frustrating bug in Safari, not fixed in v14, which is tracked here: https://bugs.webkit.org/show_bug.cgi?id=187903
When you hover the resize handle of an image with a caption, the caption travels down the page:
The precise cause is a little elusive, but it appears to be related to the
table-captionproperty used for the image caption, combined with the image itself reiving ananimationand/or atransform.This PR takes the smallest route I could think of, to improve the situation: it simplpy disables the animation in Safari using a hack documented with a comment. Safari after:
Chrome and other blink browsers are unchanged, same with Firefox. Here's Chrome:
I wish there was a better and still small fix, but I was unable to find one. Ideally this gets fixed in Safar 15, and we can remove the hack. An alternate approach is to revisit the Image block and how captions are treated, but that is a nontrivial project.