Fix missing selected block highlighting in list view #24609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Regression
talldan
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: +131 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
|
Should this highlight the block that the cursor is currently in? If yes, it's not doing it when tested. - Chrome |
|
@ntsekouras Thanks for testing. Yep, the icon for the block should display with a black background. Maybe the style is too subtle: It's also a little easy to confuse with the blue border, which is the focus ring. |
Yes. I had in mind to look for focus ring :)
IMO it might be yes, especially with black/white only contrast. You might miss that and think a selected icon is the actual icon. But this might be for another follow up issue/discussion. |
|
Thanks @ntsekouras, I made a new issue about the design - #24617. |
jorgefilipecosta
pushed a commit
that referenced
this pull request
Aug 26, 2020
* Add back missing style for selected block in list view * Override selected style on navigation screen
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #24520
#22996 accidentally removed the styles for selected blocks in list view. As mentioned in the PR description, this wasn't intended to have any effect on the post editor, only the experimental navigation editor screen.
I've added those styles back and also added some styles for the navigation screen that remove the highlight only on that screen.
How has this been tested?
Post editor
Nav Screen
Screenshots
Post editor
Nav Screen
Types of changes
Checklist: