Inserter: Update the search form placeholder text when changing tabs #24697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch box can show the correct placeholder wording.
apeatling
added
the
[Feature] Inserter
|
Size Change: +1.81 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
|
This is because the search was meant to be global but it hasn't been fully implemented yet. It might be helpful to add this clue in the meantime. cc @youknowriad |
vindl
reviewed
Aug 21, 2020
|
Seems to me this change made the "quick inserter" search input unlabelled (and with no placeholder text):
Seems to me the new function @apeatling can you please have a look, when you have a chance? Aside: as mentioned in #24494 and in other previous conversations, it would be really great to have some kind of automated tests to make sure all form elements are properly labelled, see als #6098. /Cc @youknowriad |
|
Will get this fixed this morning. 👍 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When changing tabs between: "Blocks | Patterns | Reusable", the search form does not change its placeholder text. This means when looking at the Patterns or Reusable tabs, it still says "Search for a block".
This PR makes sure that the placeholder in the search input field changes depending on the tab you have selected.
How has this been tested?
Tested locally and all tests run and passed.
Screenshots
Types of changes
Bug fix, non breaking change.
Checklist: