Remove redundant type badges in navigation link control #24885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
commented
Aug 28, 2020
packages/block-editor/src/components/link-control/test/fixtures/index.js
Show resolved
Hide resolved
|
Size Change: +42 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
kevin940726
commented
Aug 28, 2020
Comment on lines
-1220
to
+1223
| expect( currentLinkHTML ).toEqual( | ||
| expect.stringContaining( selectedLink.type ) | ||
| ); | ||
| expect( currentLinkHTML ).toEqual( expect.stringContaining( 'Edit' ) ); | ||
| expect( | ||
| queryByRole( currentLink, 'button', { name: 'Edit' } ) | ||
| ).toBeTruthy(); |
There was a problem hiding this comment.
Fixed a bad test where it's asserting the HTML to contain a Page text anywhere. It was passing because the text contains Hello Page, but not we want to test against.
Fixed it by using RTL to search for a button with the Edit text.
noisysocks
approved these changes
Sep 1, 2020
kevin940726
deleted the
update/navigation-search-results-redundant-type
branch
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #24839. Remove the type badges for Page/Post/Tag/Category.
How has this been tested?
See the unit tests, or
Screenshots
Types of changes
Bug fix
Checklist: