-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add title attribute to Navigation Link block. #24993
Conversation
Size Change: +28 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Perhaps controversial, but I am wondering if there was any discussion about not supporting the title attribute? There is still an ongoing issue about removing title attributes from core. |
Great question! With this PR we're looking to replicate the functionality in the Menus screen ( If I read the ticket you linked to above correctly, it's about removing title attributes from the admin interface, not to stop users from adding them to their content. Whether to encourage users to not use these attributes is another question (and a good one!), but would be better addressed as a separate issue. |
Description
Partially addresses #23731 by adding the "title" attribute to the Navigation Link block.
How has this been tested?
Tested in browser.
Screenshots
Types of changes
Checklist: