Add support for advanced menu item properties to Navigation screen #25062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +48 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
noisysocks
reviewed
Sep 11, 2020
Comment on lines
+158
to
+159
| xfn: block.attributes.rel.split( ' ' ), | ||
| classes: block.attributes.className.split( ' ' ), |
There was a problem hiding this comment.
This throws an error when rel or className is undefined.
- Add a new link to the Navigation screen.
- Click Save.
- Note the There was an error. message.
There was a problem hiding this comment.
Whoops, I'll fix it!
There was a problem hiding this comment.
Here: #25229
5 tasks
6 tasks
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Navigation link blocks in Navigation screen now sync their advanced properties with their corresponding menu items.
How has this been tested?
Add description, classname, rel or link title to Navigation link block in Navigation screen. Check that they are reflected in
nav-menus.php. Add properties to menu item innav-menus.phpand check that they are reflected in Navigation screen. Also check that rel, classname and link title render correctly in the front end.Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: