Fix Template Part auto-drafting to support sub-directories. #25063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addison-Stavlo
requested review from
vindl,
Copons,
david-szabo97,
jeyip and
noahtallen
Addison-Stavlo
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
Addison-Stavlo
changed the title
Addison-Stavlo
changed the title
noahtallen
approved these changes
Sep 4, 2020
lib/template-parts.php
Outdated
| $child_template_part_files = glob( get_template_directory() . '/block-template-parts/*.html' ); | ||
| $child_template_part_files = is_array( $child_template_part_files ) ? $child_template_part_files : array(); | ||
| $template_part_files = array_merge( $template_part_files, $child_template_part_files ); | ||
| $template_part_files = get_template_part_paths( get_template_directory(), $template_part_files ); |
There was a problem hiding this comment.
Could we concatenate the arrays outside of the function instead of passing it in to modify? I like how that would make the function "more pure," if that makes sense
There was a problem hiding this comment.
Yeah, that makes sense. As in b86514f?
This runs on the |
aristath
approved these changes
Sep 4, 2020
jeyip
reviewed
Sep 4, 2020
There was a problem hiding this comment.
Hmmm 🤔
I was trying to test this locally and there are duplicate template part previews for the new template part .html file I've created. Any hunch as to why?
- I'm creating files in the seedlet blocks theme
- I have distinct names for each new html file (nested within a subdirectory)
- I've tried cleaning up all the data in the WordPress instance
npx wp-env clean all - I double-checked the template parts view in wp-admin to make sure these are auto-drafted. The view is empty, so it seems like these are auto drafts.
If the duplicates are showing up for the TP in the subdirectory, it is probably because I didn't rebase since @noahtallen's fix for that in #25030 😁 . |
Addison-Stavlo
force-pushed
the
fix/template-part-auto-drafting-from-nested-files
branch
from
5d4e0eb
to
21c803b
Compare
|
Just rebased so that should be fixed here as well. |
Beat me to the punch! I was about to rebase as well. Thanks, I'll test the PR again 🙂 |
jeyip
approved these changes
Sep 4, 2020
Addison-Stavlo
deleted the
fix/template-part-auto-drafting-from-nested-files
branch
This was referenced Mar 18, 2021
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, template part auto-drafting is only done for template parts directly in the block-template-parts directory of a theme. This change updates this to handle template parts included in subdirectories of block-template-parts.
How has this been tested?
In your themes block-template-parts folder, create a new template part .html file in a sub-directory. Load the editor, and verify the auto draft for this new template part is found in the template part placeholder's selection/preview popover.
Screenshots
Types of changes
Checklist: