Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish menu item icon locations. #25106

Merged
merged 2 commits into from
Sep 7, 2020
Merged

Polish menu item icon locations. #25106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
405d839
Polish media replace menu.
jasmussen Sep 7, 2020
8d37e07
Polish transforms menu.
jasmussen Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/block-switcher/block-transformations-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ const BlockTransformationsMenu = ( {
<MenuItem
key={ name }
className={ getBlockMenuDefaultClassName( name ) }
icon={ <BlockIcon icon={ icon } showColors /> }
onClick={ ( event ) => {
event.preventDefault();
onSelect( name );
} }
>
<BlockIcon icon={ icon } showColors />
{ title }
</MenuItem>
);
Expand Down
6 changes: 5 additions & 1 deletion packages/block-editor/src/components/media-replace-flow/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@
}

.block-editor-media-flow__url-input {
margin-top: $grid-unit-20;
border-top: $border-width solid $gray-900;
margin-top: $grid-unit-15;
margin-right: -$grid-unit-15;
margin-left: -$grid-unit-15;
padding: $grid-unit-15 $grid-unit-30 0;

.block-editor-media-replace-flow__image-url-label {
top: $grid-unit-20;
Expand Down
6 changes: 6 additions & 0 deletions packages/components/src/menu-item/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@
.components-menu-item__shortcut + .components-menu-items__item-icon {
margin-left: $grid-unit-10;
}

// If a block item is shown inline (such as transforms), space it correctly.
.block-editor-block-icon {
margin-left: -2px; // This optically balances the icon.
margin-right: $grid-unit-10;
}
}

.components-menu-item__info-wrapper {
Expand Down
4 changes: 2 additions & 2 deletions packages/icons/src/library/media.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
import { SVG, Path } from '@wordpress/primitives';

const media = (
<SVG xmlns="http://www.w3.org/2000/svg" viewBox="-2 -2 24 24">
<Path d="M13 11V4c0-.55-.45-1-1-1h-1.67L9 1H5L3.67 3H2c-.55 0-1 .45-1 1v7c0 .55.45 1 1 1h10c.55 0 1-.45 1-1zM7 4.5c1.38 0 2.5 1.12 2.5 2.5S8.38 9.5 7 9.5 4.5 8.38 4.5 7 5.62 4.5 7 4.5zM14 6h5v10.5c0 1.38-1.12 2.5-2.5 2.5S14 17.88 14 16.5s1.12-2.5 2.5-2.5c.17 0 .34.02.5.05V9h-3V6zm-4 8.05V13h2v3.5c0 1.38-1.12 2.5-2.5 2.5S7 17.88 7 16.5 8.12 14 9.5 14c.17 0 .34.02.5.05z" />
<SVG xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24">
<Path d="M18.7 3H5.3C4 3 3 4 3 5.3v13.4C3 20 4 21 5.3 21h13.4c1.3 0 2.3-1 2.3-2.3V5.3C21 4 20 3 18.7 3zm.8 15.7c0 .4-.4.8-.8.8H5.3c-.4 0-.8-.4-.8-.8V5.3c0-.4.4-.8.8-.8h13.4c.4 0 .8.4.8.8v13.4zM10 15l5-3-5-3v6z" />
</SVG>
);

Expand Down