Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and make consistent post and site headers. #25134

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

jasmussen
Copy link
Contributor

This PR refactors button margins in the top toolbar, and copies them to the site editor to make it consistent.

Site and post headers after this PR:

Screenshot 2020-09-08 at 08 46 07

Screenshot 2020-09-08 at 08 46 13

Site header before:

Screenshot 2020-09-08 at 08 46 30

@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. [Type] Code Quality Issues or PRs that relate to code quality labels Sep 8, 2020
@jasmussen jasmussen self-assigned this Sep 8, 2020
@github-actions
Copy link

github-actions bot commented Sep 8, 2020

Size Change: +125 B (0%)

Total Size: 1.2 MB

Filename Size Change
build/block-editor/style-rtl.css 11.1 kB -4 B (0%)
build/block-editor/style.css 11.1 kB -4 B (0%)
build/edit-post/style-rtl.css 6.25 kB -11 B (0%)
build/edit-post/style.css 6.23 kB -11 B (0%)
build/edit-site/style-rtl.css 3.14 kB +78 B (2%)
build/edit-site/style.css 3.14 kB +77 B (2%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.41 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 8.5 kB 0 B
build/block-directory/style-rtl.css 953 B 0 B
build/block-directory/style.css 952 B 0 B
build/block-editor/index.js 128 kB 0 B
build/block-library/editor-rtl.css 8.64 kB 0 B
build/block-library/editor.css 8.64 kB 0 B
build/block-library/index.js 138 kB 0 B
build/block-library/style-rtl.css 7.59 kB 0 B
build/block-library/style.css 7.58 kB 0 B
build/block-library/theme-rtl.css 754 B 0 B
build/block-library/theme.css 754 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.7 kB 0 B
build/components/index.js 200 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 9.67 kB 0 B
build/core-data/index.js 12.3 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.55 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.48 kB 0 B
build/edit-navigation/index.js 11.7 kB 0 B
build/edit-navigation/style-rtl.css 1.16 kB 0 B
build/edit-navigation/style.css 1.16 kB 0 B
build/edit-post/index.js 305 kB 0 B
build/edit-site/index.js 17.1 kB 0 B
build/edit-widgets/index.js 12.1 kB 0 B
build/edit-widgets/style-rtl.css 2.46 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/index.js 45.6 kB 0 B
build/editor/style-rtl.css 3.81 kB 0 B
build/editor/style.css 3.81 kB 0 B
build/element/index.js 4.64 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.71 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.52 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.41 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@youknowriad youknowriad added [Feature] Full Site Editing and removed [Type] Code Quality Issues or PRs that relate to code quality labels Sep 8, 2020
@MichaelArestad
Copy link
Contributor

The only thing I noticed was that the site editor on mobile got pretty funky:

image

On master, it overflows (also bad):
image

Perhaps this would be best resolved in a separate issue?

@jasmussen
Copy link
Contributor Author

Thanks so much for looking.

I think that's definitely an issue to solve, but it was secondary to this PR. I think it's perhaps best as a separate PR because some aspects of that top heading are still very much in flux, and so it may be better to update the mobile version once that settles a bit. What do you think?

@jasmussen jasmussen merged commit 0a0885e into master Sep 11, 2020
@jasmussen jasmussen deleted the fix/consistency-between-post-site-editors branch September 11, 2020 16:58
@github-actions github-actions bot added this to the Gutenberg 9.0 milestone Sep 11, 2020
@MichaelArestad
Copy link
Contributor

I think it's perhaps best as a separate PR because some aspects of that top heading are still very much in flux, and so it may be better to update the mobile version once that settles a bit.

That makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants