Add filtering by author support in Query block #25149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Full Site Editing
[Type] Feature
ntsekouras
requested review from
ajitbohra,
nerrad,
ntwb,
Soean and
talldan
as code owners
6 tasks
|
Size Change: +139 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
mcsf
approved these changes
Sep 8, 2020
packages/block-library/src/query/edit/query-inspector-controls.js
Outdated
Show resolved
Hide resolved
packages/block-library/src/query/edit/query-inspector-controls.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
change description Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ports
authorfiltering support inQueryblock fromQueryControlswhich is used inLatest Posts.This is part of #24934 (FSE milestone 5) and #24521.
There still needs to be a decision about the final design of Query block, but that also depends on how many things we will include eventually and where ( toolbar, inspector controls etc..). IMO since it's easy to move the functionality between the toolbar and the inspector controls, this enhances the functionality of Query block and could be merged even without the finalized design.
Checklist: