Fix template part rename before customize bug. #25206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addison-Stavlo
requested review from
vindl,
Copons,
david-szabo97,
jeyip and
noahtallen
Addison-Stavlo
requested review from
ajitbohra,
Soean and
talldan
as code owners
Addison-Stavlo
added
[Feature] Full Site Editing
[Type] Bug
|
Size Change: +37 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
noahtallen
approved these changes
Sep 10, 2020
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures renaming a template-part moves it to 'publish' status if it is not already, this fixes a bug where if we rename a theme supplied template part before customizing content, it remains stuck in the auto-draft status indefinitely and is not found in our query requests for template parts.
More on the bug/background:
When a template part auto-draft is customized, it is upgraded from 'auto-draft' to 'publish' status to signify it is customized and to allow another theme default auto-draft to be created in the background.
Currently, the rename toolbar does not handle any publish status. Because of this, if you rename before customizing content, the template part will stay in auto-draft status under a slug which is not supplied by the theme and is not found in our search for template parts.
To reproduce the bug:
How has this been tested?
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: