Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Enhance Block Context documents #25272

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

atachibana
Copy link
Contributor

@mkaz @aduth

This PR is enhancement of block context:

  • Added complete example based on this guide and E2E test code.
  • Replaced block.json by example source code for consistency and easiness.
  • Added notice to block context is not available to save. This is spec. See PR Block API: Add Block Context support #21467 though I spent whole hour to search here and there ...

Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-- Errant comment. Moved to #25299

@atachibana
Copy link
Contributor Author

@mkaz
Above your comment must be another issue's, though your discussion caused my interests :-)

@mkaz
Copy link
Member

mkaz commented Sep 17, 2020

Ok, that is weird, maybe I had the tabs open wrong, that comment was intended for #25299

Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I like the full example included at the bottom.
Thanks!

@aristath aristath merged commit a19376f into WordPress:master Sep 18, 2020
@github-actions github-actions bot added this to the Gutenberg 9.1 milestone Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants