Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Featured Image: Remove redundant condition used to determine modal class #25490

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Sep 21, 2020

Description

This PR follows up on a change that should of been done in #14415, as @jorgefilipecosta pointed out in #14415 (review):

Both classes are the same -- I think we can just use modalClass="editor-post-featured-image__media-modal".

How has this been tested?

Built Gutenberg from source and verified the class is still shown.

Screenshots

N/A

Types of changes

Non-breaking change.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍 - You'll have to rebase to pass CI

@ntsekouras ntsekouras merged commit e38156c into WordPress:master Sep 22, 2020
@github-actions github-actions bot added this to the Gutenberg 9.1 milestone Sep 22, 2020
@pierlon pierlon deleted the patch-1 branch September 22, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants