[RNMobile] Fix color palette scroll within Cover placeholder #25734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Size Change: 0 B Total Size: 1.18 MB ℹ️ View Unchanged
|
lukewalczak
changed the title
Tug
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
Tested on both Android and iOS. On iOS it works as expected 🎉
On Android there's no scroll animation so I couldn't really reproduce. Also interacting with the cover block did crash the app at some point but it looks unrelated to this change. I'll keep investigating and open an issue if I find reproducible steps.
cameronvoell
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
I also don't see the scroll animation on Android, however I could produce the crash on Android before the fix, and I can not after, so I think this fix looks good. The scroll animation on iOS works for me after the fix as well, were it was previously crashing. 👍
cameronvoell
pushed a commit
that referenced
this pull request
Sep 30, 2020
cameronvoell
added a commit
that referenced
this pull request
Oct 5, 2020
* Release script: Update react-native-editor version to 1.38.0 * Release script: Update with changes from 'npm run core preios' * Update aztec reference to tagged release 1.3.45 * Correct BottomSheet in ModalLinkUI (#25740) * Pass shouldEnableBottomSheetScroll into ColorPalette (#25734) * Added changes from npm run native preios Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Tug
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: wordpress-mobile/gutenberg-mobile#2682
How has this been tested?
Screenshots
Types of changes
Pass
shouldEnableBottomSheetScrollintoColorPaletteChecklist: