FSE Document actions - wrap with heading #25874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +8.93 kB (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
Addison-Stavlo
changed the title
noahtallen
requested changes
Oct 7, 2020
packages/edit-site/src/components/header/document-actions/index.js
Outdated
Show resolved
Hide resolved
Addison-Stavlo
force-pushed
the
try/reorder-edit-site-header
branch
from
b4b44f5 to
e20859d
Compare
noahtallen
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
I think this is a solid approach which improves accessibility for folks using screen readers etc. It lets us maintain the current visual designs as well -- at least until better designs have been proposed :)
Only note is that I think it should say "edit $postType" instead of "edit document"
|
|
noahtallen
added
[a11y] Labelling
[Focus] Accessibility (a11y)
noahtallen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of re-ordering the items in the header, we will update the wrapper to be a heading element so it can be easily seen via a11y software.
Re-orders the site editor header to have document-actions to appear as the first section in the dom hierarchy (as discussed #25781).
This should introduce no visual change.
resolves #25781
How has this been tested?
Tested on local docker env.
<h1>Screenshots
This should have no visual change.
Types of changes
Checklist: