Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Unpin ignore-emit-webpack-plugin dependency #26739

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Nov 5, 2020

Description

Follow-up for #26591 that temporarily fixed #26547.

mrbar42/ignore-emit-webpack-plugin#17 (comment) - now that ignore-emit-webpack-plugin was fixed to work with both webpack v4 and v5 we can allow again to use ranges for the dependency.

Testing

I still need to figure out if there is an alternative to enforcing the latest version in the project that uses the latest version of @wordpress/scripts.

@gziolo gziolo self-assigned this Nov 5, 2020
@gziolo gziolo added the [Tool] WP Scripts /packages/scripts label Nov 5, 2020
@github-actions
Copy link

github-actions bot commented Nov 5, 2020

Size Change: 0 B

Total Size: 1.2 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.8 kB 0 B
build/api-fetch/index.js 3.42 kB 0 B
build/autop/index.js 2.83 kB 0 B
build/blob/index.js 665 B 0 B
build/block-directory/index.js 8.72 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 133 kB 0 B
build/block-editor/style-rtl.css 11.3 kB 0 B
build/block-editor/style.css 11.3 kB 0 B
build/block-library/editor-rtl.css 8.96 kB 0 B
build/block-library/editor.css 8.96 kB 0 B
build/block-library/index.js 148 kB 0 B
build/block-library/style-rtl.css 8.23 kB 0 B
build/block-library/style.css 8.23 kB 0 B
build/block-library/theme-rtl.css 792 B 0 B
build/block-library/theme.css 793 B 0 B
build/block-serialization-default-parser/index.js 1.87 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/blocks/index.js 48.1 kB 0 B
build/components/index.js 172 kB 0 B
build/components/style-rtl.css 15.3 kB 0 B
build/components/style.css 15.3 kB 0 B
build/compose/index.js 9.93 kB 0 B
build/core-data/index.js 14.8 kB 0 B
build/data-controls/index.js 827 B 0 B
build/data/index.js 9.71 kB 0 B
build/date/index.js 11.2 kB 0 B
build/deprecated/index.js 769 B 0 B
build/dom-ready/index.js 571 B 0 B
build/dom/index.js 4.92 kB 0 B
build/edit-navigation/index.js 11.2 kB 0 B
build/edit-navigation/style-rtl.css 881 B 0 B
build/edit-navigation/style.css 885 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.45 kB 0 B
build/edit-post/style.css 6.44 kB 0 B
build/edit-site/index.js 23.5 kB 0 B
build/edit-site/style-rtl.css 3.86 kB 0 B
build/edit-site/style.css 3.86 kB 0 B
build/edit-widgets/index.js 26.4 kB 0 B
build/edit-widgets/style-rtl.css 3.13 kB 0 B
build/edit-widgets/style.css 3.13 kB 0 B
build/editor/editor-styles-rtl.css 476 B 0 B
build/editor/editor-styles.css 478 B 0 B
build/editor/index.js 43.3 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.85 kB 0 B
build/element/index.js 4.62 kB 0 B
build/escape-html/index.js 735 B 0 B
build/format-library/index.js 6.86 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.27 kB 0 B
build/html-entities/index.js 623 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 698 B 0 B
build/keyboard-shortcuts/index.js 2.85 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.1 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.31 kB 0 B
build/notices/index.js 1.82 kB 0 B
build/nux/index.js 3.42 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.43 kB 0 B
build/priority-queue/index.js 790 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/reusable-blocks/index.js 2.92 kB 0 B
build/rich-text/index.js 13.4 kB 0 B
build/server-side-render/index.js 2.77 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.05 kB 0 B
build/viewport/index.js 1.86 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.22 kB 0 B

compressed-size-action

@gziolo
Copy link
Member Author

gziolo commented Nov 5, 2020

When I manually modify the version of ignore-emit-webpack-plugin inside the package.json file from @wordpress/scripts in the project scaffolded with @wordpress/create-block I get the following error:

TypeError: Cannot destructure property 'info' of 'TerserPlugin.getAsset(...)' as it is undefined.
    at TerserPlugin.taskGenerator (/Users/gziolo/Projects/esnext-example/node_modules/terser-webpack-plugin/dist/index.js:183:7)
    at taskGenerator.next (<anonymous>)
    at /Users/gziolo/Projects/esnext-example/node_modules/terser-webpack-plugin/dist/index.js:455:49
    at /Users/gziolo/Projects/esnext-example/node_modules/p-try/index.js:4:10
    at new Promise (<anonymous>)
    at pTry (/Users/gziolo/Projects/esnext-example/node_modules/p-try/index.js:3:37)
    at run (/Users/gziolo/Projects/esnext-example/node_modules/terser-webpack-plugin/node_modules/p-limit/index.js:24:18)
    at /Users/gziolo/Projects/esnext-example/node_modules/terser-webpack-plugin/node_modules/p-limit/index.js:46:18
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

So it still might be broken :(

@gziolo gziolo marked this pull request as draft November 5, 2020 16:53
@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Nov 7, 2020
Now that ignore-emit-webpack-plugin was fixed to work with both webpack v4 and v5 we can allow again to use ranges for the dependency.
@gziolo gziolo force-pushed the update/scripts-ignore-emit-webpack branch from 5ab9a91 to e7dfcd9 Compare November 23, 2020 14:33
@gziolo
Copy link
Member Author

gziolo commented Nov 23, 2020

It tests properly with v2.0.6, see mrbar42/ignore-emit-webpack-plugin#17 (comment).

@gziolo gziolo marked this pull request as ready for review November 23, 2020 14:34
@gziolo gziolo removed the [Status] In Progress Tracking issues with work in progress label Nov 23, 2020
@gziolo gziolo merged commit 78bb110 into master Nov 23, 2020
@gziolo gziolo deleted the update/scripts-ignore-emit-webpack branch November 23, 2020 15:12
@github-actions github-actions bot added this to the Gutenberg 9.5 milestone Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Tool] WP Scripts /packages/scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with npx @wordpress/create-block
1 participant