-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts: Unpin ignore-emit-webpack-plugin dependency #26739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
When I manually modify the version of
So it still might be broken :( |
Now that ignore-emit-webpack-plugin was fixed to work with both webpack v4 and v5 we can allow again to use ranges for the dependency.
gziolo
force-pushed
the
update/scripts-ignore-emit-webpack
branch
from
November 23, 2020 14:33
5ab9a91
to
e7dfcd9
Compare
It tests properly with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #26591 that temporarily fixed #26547.
mrbar42/ignore-emit-webpack-plugin#17 (comment) - now that
ignore-emit-webpack-plugin
was fixed to work with both webpack v4 and v5 we can allow again to use ranges for the dependency.Testing
I still need to figure out if there is an alternative to enforcing the latest version in the project that uses the latest version of
@wordpress/scripts
.