-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default block widths to the full-site editor #26853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Bug
An existing feature does not function as intended
[Feature] Themes
Questions or issues with incorporating or styling blocks in a theme.
[Feature] Full Site Editing
labels
Nov 10, 2020
Size Change: +72 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
hc0503
approved these changes
Nov 10, 2020
jasmussen
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Nice.
At first I couldn't reproduce. But turns out I had defined the wide and fullwide widths myself in my editor style. And sure enough, they're not there by default.
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Themes
Questions or issues with incorporating or styling blocks in a theme.
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26630.
The full-site editor does not currently set the default widths for blocks, leaving all blocks to appear full-width unless a theme specifically adds a max-width.
This PR brings the max-width rules from
edit-post
intoedit-site
too. I created a mixin for them to avoid duplicating code. I also moved the wide-content width (1100px) into a new variable since it was used in multiple places.Testing
*You can use Twenty Twenty-One Blocks if you remove these lines.