Expand the multi-entity saving panel by default #27437
Conversation
youknowriad
added
Needs Design Feedback
|
I just moved ahead and removed the ability to expand the changes entirely. What do you think? |
|
I think that is a little more tricky. If there are lots of changes in different contexts (template + parts + global styles + content + site data) it may be more convenient to work through them one section at a time, and collapsing may help with that? No strong opinion here though. Probably fine to remove the collapsibility for now if it's easy to add back. I'll defer to @jasmussen on this :D |
|
Size Change: -32 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
On the one hand, I have a semi strong opinion that the entire reason we have a pre-publish panel in the first place is to show exactly this, so if we don't do that, why even have a prepublish dialog. And furthermore, when a panel defaults to open, and doesn't save its state across sessions, it shouldn't need the ability to collapse. On the other hand, I recall @mtias expressing, at times, the desire to keep multi entity saving simple, because most of the time and when you are in a site editing context, you know what you're doing. In absence of him chiming in, I'd say remove it. And if he chimes in later and disagrees, one round on me 😅
This double border annoys me, though 😅 — and now I want to eat at Pizza Planet. |
|
Oh wait just to be clear, it's this blue "hide changes" link that I mean we should remove:
I don't mind keeping these collapsible:
|
|
I removed the double border already :) |
|
@jasmussen that's what I did already. |
|
Sigh. One round on me, clearly. You're too fast for me Riad. |
|
Yes, please! :) |
youknowriad
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
|
Sorry for being late to the party.
I am on board with this change. That was the original idea when moving it over from the old modal.
If its open by default, I don't think there is a need for the expand/collapse option. Pinging @MichaelArestad as he might have some thoughts on this. IIRC he is the one that convinced us to go with trying the hidden by default expanding panel approach. |
Follow up to #26355
Based on some discussion with @jameskoster and @jasmussen it was decided that this multi-entity saving panel should be expanded by default.
Testing instructions