Refactor the EditorProvider component and extract hooks #27605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
|
Size Change: +114 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Dec 9, 2020
| }, [] ); | ||
| const { id, type } = __unstableTemplate ?? post; | ||
| const blockEditorProps = usePostContentEditor( type, id ); | ||
| const editorSettings = useBlockEditorSettings( |
packages/editor/src/components/provider/use-block-editor-settings.js
Outdated
Show resolved
Hide resolved
youknowriad
force-pushed
the
update/refactor-editor-provider
branch
from
22af4db
to
d946c4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of template mode #26355 and a couple of other things added over time, the EditorProvider component has grown to become a bit mysterious and very hard to understand.
This PR refactors it as a functional component and extract some meaningful hooks from it for better separation of concerns.
usePostContentEditorto bridge between a posttype/postId and the state in core/datauseBlockEditorSettingshook to separate the computation of the block editor settings from the initialization work done by EditorProvider.I think there's a lot more potential for refactoring that can be done, especially related to the initialization effect (why don't we just remove the initialization step completely and have the component react to changes).
This PR kept the flows exactly the same.