Scripts: ESLint minor version upgrade to 7.17.0 #27965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
force-pushed
the
update/eslint-minor-upgrade
branch
from
d54b19b
to
0039ef0
Compare
gziolo
added
[Tool] ESLint plugin
gziolo
changed the title
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
gziolo
requested review from
adamsilverstein,
ajitbohra,
cameronvoell,
chrisvanpatten,
dmsnell,
ellatrix,
guarani,
mmtr,
nerrad,
noahtallen,
ntwb and
talldan
as code owners
|
Hey there @gziolo 👋 We're using gb-mobile uses metro as a packager/resolver with a custom config and now it seems We're thinking of adding a custom resolver to Any ideas, insights or suggestions around this? |
|
@ceyhun, actually those checks are disabled for React Native code in Gutenberg: You can follow the same approach for start. In the long run we can add s as custom resolver to account for React Native 👍 |
2 tasks
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades ESLint to the latest version for Gutenberg and
@wordpress/scripts. ESLint upgrade is itself a minor version upgrade. However, some plugins and config used contain breaking changes which means that overall it's going to be a major version bump for two packages as listed.@wordpress/eslint-pluginBreaking Changes:
eslint-config-prettierdependency has been updated from requiring^6.10.1to requiring^7.1.0.eslint-plugin-jestdependency has been updated from requiring^23.8.2to requiring^24.1.3.Enhancements:
eslint-plugin-jsdocdependency has been updated from requiring^30.2.2to requiring^30.7.13.eslint-plugin-jsx-a11ydependency has been updated from requiring^6.2.3to requiring^6.4.1.eslint-plugin-prettierdependency has been updated from requiring^3.1.2to requiring^3.3.0.eslint-plugin-reactdependency has been updated from requiring^7.20.0to requiring^7.22.0.eslint-plugin-react-hooksdependency has been updated from requiring^4.0.4to requiring^4.2.0.@wordpress/scriptsBreaking Changes:
@wordpress/eslint-plugindependency has been updated to the next major version^8.0.0. There are new ESLint rules enabled in the recommended config used bylint-jscommand.Enhancements:
eslintdependency has been updated from requiring^7.1.0to requiring^7.17.0.How has this been tested?
npm run lint-jsTypes of changes
Checklist: