Fix isRTL check by loading the ltr string explilcitely #28279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: +96 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Co-authored-by: Jon Surrell <jon.surrell@automattic.com>
sirreal
approved these changes
Jan 18, 2021
ockham
pushed a commit
that referenced
this pull request
Jan 18, 2021
Co-authored-by: Jon Surrell <jon.surrell@automattic.com>
ockham
pushed a commit
that referenced
this pull request
Jan 18, 2021
Co-authored-by: Jon Surrell <jon.surrell@automattic.com>
|
Cherry-picked to both |
|
Hey @youknowriad, do you know if this change needs to be made in |
6 tasks
|
@noisysocks I think it's one of :
I added the label here so we don't forget. It's easy to test though: just run |
|
I dug into this some more. Even if the infinite recursion bug is fixed, we can still not use Our options are to keep the fix in this PR even after https://core.trac.wordpress.org/ticket/46089 is fixed or to move |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
|
Removing the backport label here as we have https://core.trac.wordpress.org/ticket/52441 which tracks adding this to Core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #28221
closes #28252
Due to potential infinite loop, translations for i18n script are not being loaded. This PR makes sure we load the "ltr" string as an inline script.
The root issue is being tackled in https://core.trac.wordpress.org/ticket/46089
Testing instructions