Enable alignments/width for all blocks by default #28349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Blocks
youknowriad
requested review from
ajitbohra,
ajlende and
ellatrix
as code owners
|
Size Change: +56 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
|
Cool work. I'm not seeing any controls though? I'm looking at the paragraph and was hoping to see some alignment controls in the sidebar. |
|
Oh I forgot to mention the paragraph block :) That one is special because it already has an "align" attribute so I can't just go ahead and and activate the hook there. We need one of these: 1- Rename the current "align" attribute of the paragraph to "textAlign" and enable the align hook I'd personally prefer 4 followed by 1 but both of these solutions have backward compatibility implications. |
|
Ah, thanks for the clarification. Agreed, option 4 looks good. I see the align dropdown on the other blocks:
I don't think we can add more to the block toolbar to these blocks, they are already pretty heavy. I think the approach we need to take is to:
Here are some mockups from #27331 which incorporate the alignment into the sidebar:
|
|
Wrote a plan for this in #25973 I'm closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion #25973
We have right now some arbitrary decisions about which blocks do or do not support alignments. This PR tries to address this by:
This is just a POC for now just to get a sense of what really needs to be done and figure out the backward compatibility story.