Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeated backgrounds with transparent images #28362

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Jan 20, 2021

Description

See #28310 (comment)

cover-srcset-repeated.mp4

In re-enabling the image repeat feature, I missed removing the <img> element when it was enabled. This removes that <img> element when the repeat feature is enabled. Thanks again to @stokesman!

How has this been tested?

Easiest to see with an image using transparency or a small image, enable the repeat feature and see that there isn't an overlapping image with the background.

Screenshots

Screen Shot 2021-01-20 at 08 11 53-fullpage

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ajlende ajlende added [Type] Bug An existing feature does not function as intended [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Jan 20, 2021
@ajlende ajlende requested a review from mkaz January 20, 2021 18:13
@ajlende ajlende self-assigned this Jan 20, 2021
@ajlende ajlende requested a review from ajitbohra as a code owner January 20, 2021 18:13
@ajlende ajlende force-pushed the fix/transparent-cover-img branch from 2a42e0c to 65f7c9c Compare January 20, 2021 18:16
@ajlende ajlende force-pushed the fix/transparent-cover-img branch from 65f7c9c to fdef2cb Compare January 21, 2021 18:09
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test previously with an image that had transparency, so missed this previous.
It looks fine now, tested with small transparent image and don't notice the same.

@ajlende ajlende mentioned this pull request Jan 21, 2021
6 tasks
@ajlende ajlende merged commit 69027a0 into WordPress:master Jan 22, 2021
@ajlende ajlende deleted the fix/transparent-cover-img branch January 22, 2021 23:35
@github-actions github-actions bot added this to the Gutenberg 9.9 milestone Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants