Try: Alternate cover fix. #28365
Closed
Try: Alternate cover fix. #28365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
ZebulanStanphill
added
[Block] Cover
ockham
force-pushed
the
try/matrix-alignment-2
branch
from
294cc2e to
d8059c4
Compare
|
Rebased. |
|
I've tested this across the Twenties, and it looks good in both the editor and on the frontend in the more recent ones. However, in 2014, 2013, and 2012, I see the following glitch:
|
|
Right aligned Cover block, frontend, 2020, has the same issue as #28404:
(The horizontal lines are part of 2020's post layout.) |
|
In the editor, for reference:
|
This seems to be pre-existing in |
|
After diving a bit into #28404 (comment), I'm going to close this one in favor of that. The rabbit hole is a bit deep, as the testing has revealed. So I'll pool my resources there. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #28350, possibly followup to #28364. It still needs a good sanity check and testing, but I believe that the fundamental issue with the shifting background image is related to collapsing margins for the paragraph being positioned by the matrix. By applying some left/top positioning coordinates, it should address the fundamental issue. It works well for me:
Be sure to test this in a few themes with frontend and editor both.